[ACS-6211] Fixed UI alignment issues in create rules screen (CardView and child components) #9101
Conversation
swapnil-verma-gl
requested review from
MichalKinas,
AleksanderSklorz and
dominikiwanekhyland
swapnil-verma-gl
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
| @@ -22,7 +22,14 @@ import { BaseCardView } from '../base-card-view'; | |||
|
|
|||
| @Component({ | |||
| selector: 'adf-card-view-boolitem', | |||
| templateUrl: './card-view-boolitem.component.html' | |||
| templateUrl: './card-view-boolitem.component.html', | |||
| styles: [ | |||
There was a problem hiding this comment.
Isn't it better and more clear to move it to .scss file?
There was a problem hiding this comment.
The only reason I added it here is because it's only a single class, and the scss file did not exist. However, if needed, I can create a new file and add the styling to that instead.
...ore/src/lib/card-view/components/card-view-selectitem/card-view-selectitem.component.spec.ts
Show resolved
Hide resolved
| @@ -11,7 +7,8 @@ | |||
| data-automation-class="read-only-value">{{ (property.displayValue | async) | translate }} | |||
| </div> | |||
| <div *ngIf="isEditable()"> | |||
| <mat-form-field class="adf-select-item-padding-editable adf-property-value"> | |||
| <mat-form-field class="adf-property-value" appearance="standard"> | |||
| <mat-label>{{ property.label }}</mat-label> | |||
There was a problem hiding this comment.
Isn't it the breaking change for some use cases? Right now the label will only be displayed when the field is editable
There was a problem hiding this comment.
Re-added the label only for non-editable mode. For editable mode, we are still using the mat-label introduced in this PR. The reason I went for this approach is to maintain consistency of this component with the rest of the applications. I've also added corresponding unit tests for both the labels
swapnil-verma-gl
force-pushed
the
dev-swapnil-acs-6211-card-view-item-ui-issue
branch
from
703c444 to
9999720
Compare
…ard-view and child components)
…ard-view-selectitem.component is in non-editable mode. Added corresponding tests
swapnil-verma-gl
force-pushed
the
dev-swapnil-acs-6211-card-view-item-ui-issue
branch
from
9999720 to
bedfbf1
Compare
|
swapnil-verma-gl
requested review from
MichalKinas,
dominikiwanekhyland and
AleksanderSklorz
swapnil-verma-gl
deleted the
dev-swapnil-acs-6211-card-view-item-ui-issue
branch
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
UI for the cardView Component when viewed inside CreateRules section in ACA had alignment issues
What is the new behaviour?
Adjusted the UI/styling slightly, to fix alignment issues
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
This PR links to this comment on this PR