-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-6211] Resolved UI alignment issue in create rule dialog #3505
Conversation
@swapnil-verma-gl there are still some options which has not aligned parameters: See - "select an action" and "Aspect" fields are not aligned (are not in the same line) |
That is a change that would need to be done in ADF, since the component being used here for the dropdown comes from ADF (card-view-selectitem.component). If we want, I can raise another PR for it in the ADF repo for the fix once the ADF code freeze is over |
@swapnil-verma-gl yes, please raise fix for this too if possible. I think it was one of main purposes of raising this jira. If you check Akash's video (for example 9th second) attached to this jira then you can see he is showing that these fields are unaligned. I think as part of that jira we should ensure that all parameters are aligned properly for their actions. |
b7b324c
to
2b600d0
Compare
@AleksanderSklorz Raised this PR for fixing the UI issues in ADF |
@swapnil-verma-gl this issue is resolved with newest changes now but I can see other places which are not aligned like: "Destination folder" is a bit not aligned if you compare it with left field. |
Thank you @AleksanderSklorz. The alignment issue has been resolved with this commit |
ad73c44
to
5ca8d72
Compare
5ca8d72
to
d95fb31
Compare
…l - Expansion panel items
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Create rule dialog had minor UI alignment issues
What is the new behaviour?
Fixed alignment issues
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: