Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6211] Resolved UI alignment issue in create rule dialog #3505

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

swapnil-verma-gl
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Create rule dialog had minor UI alignment issues

What is the new behaviour?
Fixed alignment issues

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@AleksanderSklorz
Copy link
Contributor

@swapnil-verma-gl there are still some options which has not aligned parameters:
image

See - "select an action" and "Aspect" fields are not aligned (are not in the same line)

@swapnil-verma-gl
Copy link
Contributor Author

@swapnil-verma-gl there are still some options which has not aligned parameters: image

See - "select an action" and "Aspect" fields are not aligned (are not in the same line)

That is a change that would need to be done in ADF, since the component being used here for the dropdown comes from ADF (card-view-selectitem.component). If we want, I can raise another PR for it in the ADF repo for the fix once the ADF code freeze is over

@AleksanderSklorz
Copy link
Contributor

@swapnil-verma-gl there are still some options which has not aligned parameters: image
See - "select an action" and "Aspect" fields are not aligned (are not in the same line)

That is a change that would need to be done in ADF, since the component being used here for the dropdown comes from ADF (card-view-selectitem.component). If we want, I can raise another PR for it in the ADF repo for the fix once the ADF code freeze is over

@swapnil-verma-gl yes, please raise fix for this too if possible. I think it was one of main purposes of raising this jira. If you check Akash's video (for example 9th second) attached to this jira then you can see he is showing that these fields are unaligned.

I think as part of that jira we should ensure that all parameters are aligned properly for their actions.

@swapnil-verma-gl
Copy link
Contributor Author

@swapnil-verma-gl there are still some options which has not aligned parameters: image
See - "select an action" and "Aspect" fields are not aligned (are not in the same line)

That is a change that would need to be done in ADF, since the component being used here for the dropdown comes from ADF (card-view-selectitem.component). If we want, I can raise another PR for it in the ADF repo for the fix once the ADF code freeze is over

@swapnil-verma-gl yes, please raise fix for this too if possible. I think it was one of main purposes of raising this jira. If you check Akash's video (for example 9th second) attached to this jira then you can see he is showing that these fields are unaligned.

I think as part of that jira we should ensure that all parameters are aligned properly for their actions.

@AleksanderSklorz Raised this PR for fixing the UI issues in ADF

@AleksanderSklorz
Copy link
Contributor

@swapnil-verma-gl there are still some options which has not aligned parameters: image
See - "select an action" and "Aspect" fields are not aligned (are not in the same line)

That is a change that would need to be done in ADF, since the component being used here for the dropdown comes from ADF (card-view-selectitem.component). If we want, I can raise another PR for it in the ADF repo for the fix once the ADF code freeze is over

@swapnil-verma-gl yes, please raise fix for this too if possible. I think it was one of main purposes of raising this jira. If you check Akash's video (for example 9th second) attached to this jira then you can see he is showing that these fields are unaligned.

I think as part of that jira we should ensure that all parameters are aligned properly for their actions.

@swapnil-verma-gl this issue is resolved with newest changes now but I can see other places which are not aligned like:

image

"Destination folder" is a bit not aligned if you compare it with left field.

@swapnil-verma-gl
Copy link
Contributor Author

@swapnil-verma-gl there are still some options which has not aligned parameters: image
See - "select an action" and "Aspect" fields are not aligned (are not in the same line)

That is a change that would need to be done in ADF, since the component being used here for the dropdown comes from ADF (card-view-selectitem.component). If we want, I can raise another PR for it in the ADF repo for the fix once the ADF code freeze is over

@swapnil-verma-gl yes, please raise fix for this too if possible. I think it was one of main purposes of raising this jira. If you check Akash's video (for example 9th second) attached to this jira then you can see he is showing that these fields are unaligned.
I think as part of that jira we should ensure that all parameters are aligned properly for their actions.

@swapnil-verma-gl this issue is resolved with newest changes now but I can see other places which are not aligned like:

image "Destination folder" is a bit not aligned if you compare it with left field.

Thank you @AleksanderSklorz. The alignment issue has been resolved with this commit

@swapnil-verma-gl swapnil-verma-gl force-pushed the dev-swapnil-acs-6211-create-rule-ui branch from ad73c44 to 5ca8d72 Compare November 27, 2023 08:33
@swapnil-verma-gl swapnil-verma-gl force-pushed the dev-swapnil-acs-6211-create-rule-ui branch from 5ca8d72 to d95fb31 Compare December 5, 2023 07:49
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@swapnil-verma-gl swapnil-verma-gl merged commit 34c8976 into develop Dec 6, 2023
25 checks passed
@swapnil-verma-gl swapnil-verma-gl deleted the dev-swapnil-acs-6211-create-rule-ui branch December 6, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants