Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-8999] rename confirmation button label for closing conversation dialog #10431

Conversation

AleksanderSklorz
Copy link
Contributor

@AleksanderSklorz AleksanderSklorz commented Nov 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8999

What is the new behaviour?
New suggested label is displayed properly.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
ACA PR: Alfresco/alfresco-content-app#4261

Sorry, something went wrong.

…ifferent size of buttons, allowed to set maxWidth of unsaved changes dialog
@AleksanderSklorz AleksanderSklorz merged commit bf58a19 into develop Nov 28, 2024
18 checks passed
@AleksanderSklorz AleksanderSklorz deleted the ACS-8999-rename-confirmation-button-label-for-closing-conversation-dialog branch November 28, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants