[ACS-8999] rename confirmation button label for closing conversation …

…dialog (#10431) * [ACS-8999] Correct styles for buttons in unsaved changes dialog for different size of buttons, allowed to set maxWidth of unsaved changes dialog * [ACS-8999] Unit tests
Alfresco · Nov 28, 2024 · bf58a19 · bf58a19
1 parent de391a2
commit bf58a19
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 2 deletions.
diff --git a/lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.component.scss b/lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.component.scss
@@ -36,6 +36,7 @@
         &-actions {
             margin-top: 11px;
             margin-bottom: 1px;
+            margin-left: 40px;
             padding: 0;
             align-items: flex-end;
 
@@ -51,7 +52,6 @@
 
             &-cancel-button,
             &-discard-changes-button {
-                padding: 4px 12px;
                 height: 32px;
                 display: flex;
                 align-items: center;

diff --git a/lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.model.ts b/lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.model.ts
@@ -20,4 +20,5 @@ export interface UnsavedChangesDialogData {
     confirmButtonText?: string;
     descriptionText?: string;
     headerText?: string;
+    maxWidth?: number | string;
 }
diff --git a/lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes.guard.spec.ts b/lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes.guard.spec.ts
@@ -123,6 +123,33 @@ describe('UnsavedChangesGuard', () => {
                 expectGuardToBe(true, done, true);
                 afterClosed$.next(false);
             });
+
+            it('should call open on dialog with correct parameters when maxWidth is not set', () => {
+                guard.unsaved = true;
+                guard.data = {
+                    headerText: 'header'
+                };
+
+                guard.canDeactivate();
+                expect(dialog.open).toHaveBeenCalledWith(UnsavedChangesDialogComponent, {
+                    maxWidth: 346,
+                    data: guard.data
+                });
+            });
+
+            it('should call open on dialog with correct parameters when maxWidth is set', () => {
+                guard.unsaved = true;
+                guard.data = {
+                    headerText: 'header',
+                    maxWidth: 'none'
+                };
+
+                guard.canDeactivate();
+                expect(dialog.open).toHaveBeenCalledWith(UnsavedChangesDialogComponent, {
+                    maxWidth: 'none',
+                    data: guard.data
+                });
+            });
         });
 
         describe('Without auth', () => {

diff --git a/lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes.guard.ts b/lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes.guard.ts
@@ -49,7 +49,7 @@ export class UnsavedChangesGuard implements CanDeactivate<any> {
         return this.unsaved
             ? this.dialog
                   .open<UnsavedChangesDialogComponent>(UnsavedChangesDialogComponent, {
-                      maxWidth: 346,
+                      maxWidth: this.data?.maxWidth ?? 346,
                       data: this.data
                   })
                   .afterClosed()