Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6791] Restore&fix excluded tests #3649

Merged
merged 3 commits into from
Feb 21, 2024
+6 −10
Merged

[ACS-6791] Restore&fix excluded tests #3649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29b9432
Reverted excluded tests
katarzynakita Feb 16, 2024
cc6793a
Removed tests from excluded, small fixes
katarzynakita Feb 16, 2024
cb68901
Added missing new line
katarzynakita Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions e2e/playwright/info-drawer/exclude.tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
{
"C299195" : "https://alfresco.atlassian.net/browse/ACS-6688",
"C299189" : "https://alfresco.atlassian.net/browse/ACS-6688"
}
{}
4 changes: 1 addition & 3 deletions e2e/playwright/library-actions/exclude.tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
{
"C286326": "https://alfresco.atlassian.net/browse/ACS-6688"
}
{}
2 changes: 2 additions & 0 deletions e2e/playwright/library-actions/src/tests/library-actions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*!

Check failure on line 1 in e2e/playwright/library-actions/src/tests/library-actions.spec.ts

View workflow job for this annotation

GitHub Actions / E2e test suites: Playwright (library-actions, 11)

[Library Actions] › src/tests/library-actions.spec.ts:369:9 › Library actions › Search Page › [C306961] Leave a library from Search Results 

  1) [Library Actions] › src/tests/library-actions.spec.ts:369:9 › Library actions  › Search Page › [C306961] Leave a library from Search Results 
    Pending operations:
      - locator.waitFor at projects/aca-playwright-shared/src/page-objects/components/spinner.component.ts:37:31
* Copyright © 2005-2023 Hyland Software, Inc. and its affiliates. All rights reserved.
*
* Alfresco Example Content Application
Expand Down Expand Up @@ -89,7 +89,7 @@
let adminSitesApi: SitesApi;
let user2SitesApi: SitesApi;

test.beforeAll(async () => {

Check failure on line 92 in e2e/playwright/library-actions/src/tests/library-actions.spec.ts

View workflow job for this annotation

GitHub Actions / E2e test suites: Playwright (library-actions, 11)

[Library Actions] › src/tests/library-actions.spec.ts:369:9 › Library actions › Search Page › [C306961] Leave a library from Search Results 

  1) [Library Actions] › src/tests/library-actions.spec.ts:369:9 › Library actions  › Search Page › [C306961] Leave a library from Search Results 
    "beforeAll" hook timeout of 200000ms exceeded.

      90 |   let user2SitesApi: SitesApi;
      91 |
    > 92 |   test.beforeAll(async () => {
         |        ^
      93 |     test.setTimeout(timeouts.extendedLongTest);
      94 |     const apiClientFactory = new ApiClientFactory();
      95 |     const username1 = `user-${Utils.random()}`;

        at /home/runner/work/alfresco-content-app/alfresco-content-app/e2e/playwright/library-actions/src/tests/library-actions.spec.ts:92:8
test.setTimeout(timeouts.extendedLongTest);
const apiClientFactory = new ApiClientFactory();
const username1 = `user-${Utils.random()}`;
Expand Down Expand Up @@ -224,6 +224,7 @@
await myLibrariesPage.reload({ waitUntil: domContentLoadedString });
await expect(libraryTable.getRowByName(user2Library2)).toBeVisible();
await libraryTable.getRowByName(user2Library2).click();
await myLibrariesPage.page.waitForTimeout(1000);
katarzynakita marked this conversation as resolved.
Show resolved Hide resolved
await myLibrariesHeader.clickMoreActions();
expect(await libraryMenu.isMenuItemVisible(removeFavoriteButton)).toBe(true);
await libraryMenu.clickMenuItem(removeFavoriteButton);
Expand Down Expand Up @@ -416,6 +417,7 @@
await expect(libraryTable.getRowByName(user2Library4)).toBeVisible();
await searchPage.reload({ waitUntil: domContentLoadedString });
await libraryTable.getRowByName(user2Library4).click();
await searchPage.page.waitForTimeout(1000);
await searchHeader.clickMoreActions();
await libraryMenu.clickMenuItem(removeFavoriteButton);
await searchHeader.clickMoreActions();
Expand Down
5 changes: 2 additions & 3 deletions projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export class AdfInfoDrawerComponent extends BaseComponent {
public propertiesTab = this.page.getByRole('tab', { name: 'Properties' });
public commentsTab = this.page.getByRole('tab', { name: 'Comments' });
public infoDrawerTabs = this.getChild('.adf-info-drawer-tab');
public commentInputField = this.getChild('mat-form-field');
public commentInputField = this.page.locator('#comment-input');
public commentsHeader = this.getChild('#comment-header');
public addCommentButton = this.getChild('[data-automation-id="comments-input-add"]');
public commentsList = this.getChild('.adf-comment-list-item');
Expand Down Expand Up @@ -79,8 +79,7 @@ export class AdfInfoDrawerComponent extends BaseComponent {
}

async addCommentToNode(commentText: string): Promise<void> {
await this.commentInputField.click();
await this.page.keyboard.type(commentText);
await this.commentInputField.fill(commentText);
await this.addCommentButton.click();
}

Expand Down
Loading