Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6791] Restore&fix excluded tests #3649

Merged
merged 3 commits into from
Feb 21, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed tests from excluded, small fixes
  • Loading branch information
katarzynakita committed Feb 21, 2024
commit cc6793a72c1a468818d25d260650d3dde0b4dc6d
4 changes: 1 addition & 3 deletions e2e/playwright/library-actions/exclude.tests.json
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
{
"C286326": "https://alfresco.atlassian.net/browse/ACS-6688"
}
{}
Original file line number Diff line number Diff line change
@@ -224,6 +224,7 @@ test.describe('Library actions ', () => {
await myLibrariesPage.reload({ waitUntil: domContentLoadedString });
await expect(libraryTable.getRowByName(user2Library2)).toBeVisible();
await libraryTable.getRowByName(user2Library2).click();
await myLibrariesPage.page.waitForTimeout(1000);
katarzynakita marked this conversation as resolved.
Show resolved Hide resolved
await myLibrariesHeader.clickMoreActions();
expect(await libraryMenu.isMenuItemVisible(removeFavoriteButton)).toBe(true);
await libraryMenu.clickMenuItem(removeFavoriteButton);
@@ -416,6 +417,7 @@ test.describe('Library actions ', () => {
await expect(libraryTable.getRowByName(user2Library4)).toBeVisible();
await searchPage.reload({ waitUntil: domContentLoadedString });
await libraryTable.getRowByName(user2Library4).click();
await searchPage.page.waitForTimeout(1000);
await searchHeader.clickMoreActions();
await libraryMenu.clickMenuItem(removeFavoriteButton);
await searchHeader.clickMoreActions();
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ export class AdfInfoDrawerComponent extends BaseComponent {
public propertiesTab = this.page.getByRole('tab', { name: 'Properties' });
public commentsTab = this.page.getByRole('tab', { name: 'Comments' });
public infoDrawerTabs = this.getChild('.adf-info-drawer-tab');
public commentInputField = this.getChild('mat-form-field');
public commentInputField = this.page.locator('#comment-input');
public commentsHeader = this.getChild('#comment-header');
public addCommentButton = this.getChild('[data-automation-id="comments-input-add"]');
public commentsList = this.getChild('.adf-comment-list-item');
@@ -79,8 +79,7 @@ export class AdfInfoDrawerComponent extends BaseComponent {
}

async addCommentToNode(commentText: string): Promise<void> {
await this.commentInputField.click();
await this.page.keyboard.type(commentText);
await this.commentInputField.fill(commentText);
await this.addCommentButton.click();
}