Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-5014] Migrated Copy Move actions E2Es from protractor to playwright #3531

Merged
merged 17 commits into from
Dec 6, 2023
Merged

[ACS-5014] Migrated Copy Move actions E2Es from protractor to playwright #3531

merged 17 commits into from
Dec 6, 2023

Conversation

swapnil-verma-gl
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:
    Migration of E2E test cases from protractor to playwright

What is the current behaviour? (You can also link to an open issue here)
Copy Move Actions e2es were implemented in protractor

What is the new behaviour?
Migrated the E2Es to playwright

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@swapnil-verma-gl swapnil-verma-gl mentioned this pull request Nov 21, 2023
Merged
DenysVuika
DenysVuika reviewed Nov 21, 2023
View reviewed changes
e2e/playwright/copy-move-actions/src/tests/destination-picker-dialog.test.ts Outdated

import { ApiClientFactory, MyLibrariesPage, NodesApi, SitesApi, test, Utils } from '@alfresco/playwright-shared';
import { expect } from '@playwright/test';
import { logger } from '@alfresco/adf-cli/scripts/logger';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be other logger for tests, we should not import adf cli into the e2e.... alternatively can use just "console.error"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrated logger from adf-cli to adf-testing. However, while looking into this, I also noticed that the same adf-cli logger is being used create-library.spec.ts as well as create-folder.spec.ts. If we want, I can update those imports as well. Just note that they are not at all related to the changes/objective of this PR

DenysVuika
DenysVuika reviewed Nov 21, 2023
View reviewed changes
e2e/playwright/copy-move-actions/src/tests/move.test.ts Outdated

import { ApiClientFactory, test, Utils, PersonalFilesPage, NodesApi, LoginPage } from '@alfresco/playwright-shared';
import { expect } from '@playwright/test';
import { logger } from '@alfresco/adf-cli/scripts/logger';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, adf cli should not be used for e2e

@AleksanderSklorz
Copy link
Contributor

please don't forget about SonarCloud issues:
image

@DenysVuika
Copy link
Contributor

needs rebase

@swapnil-verma-gl
[ACS-5014] Added test case IDs to E2E tests
c7da56c
@swapnil-verma-gl
[ACS-6211] Removed TODO note. Removed protractor test case files
d3628f2
@swapnil-verma-gl
[ACS-5014] Added E2E tests for Destination Picker in copy-move actions
915c903
@swapnil-verma-gl
[ACS-5014] Removed unneded only from test suite
976dc3a
@swapnil-verma-gl
[ACS-5014] Updated import of logger from @alfresco/adf-cli to @alfres…
423ccba 
…co/adf-testing
@swapnil-verma-gl
[ACS-5014] Addressed code review findings. Moved objects to beforeAll…
1f04bd6 
…/beforeEach wherever applicable. Added missing await.
@swapnil-verma-gl
[ACS-5014] Addressed code review findings. Removed unused methods/obj…
08aabec 
…ects from content-node-selector-dialog.ts
@swapnil-verma-gl
[ACS-5014] Addressed code review findings. Removed unused methods/obj…
af14724 
…ects from content-node-selector-dialog.ts
@swapnil-verma-gl
[ACS-5014] SonarLint fix
0d7c9d2
@swapnil-verma-gl
[ACS-5014] Fixed breaking change for other E2Es
764fc00
@swapnil-verma-gl swapnil-verma-gl force-pushed the dev-acs-5014-copy-move-actions-playwright branch from 953811f to 764fc00 Compare December 5, 2023 07:53
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
23.3% 23.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@swapnil-verma-gl swapnil-verma-gl merged commit f917a66 into develop Dec 6, 2023
24 of 25 checks passed
@swapnil-verma-gl swapnil-verma-gl deleted the dev-acs-5014-copy-move-actions-playwright branch December 6, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

@akashrathod28 akashrathod28 Awaiting requested review from akashrathod28

@MichalKinas MichalKinas Awaiting requested review from MichalKinas

@eromano eromano Awaiting requested review from eromano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swapnil-verma-gl @AleksanderSklorz @DenysVuika