Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADST-422 #73

Merged
merged 3 commits into from
Jul 5, 2024
Merged

ADST-422 #73

merged 3 commits into from
Jul 5, 2024

Conversation

aman-alfresco
Copy link
Contributor

  • added auth0 authentication

gl-lovekesh
gl-lovekesh reviewed Jul 5, 2024
View reviewed changes
auth/src/main/java/com/alfresco/auth/AuthInterceptor.kt Outdated
override fun intercept(chain: Interceptor.Chain): Response {
val response = chain.proceed(AuthType.OIDC, accessToken)

// When unauthorized try to refresh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

gl-lovekesh
gl-lovekesh reviewed Jul 5, 2024
View reviewed changes
auth/src/main/java/com/alfresco/auth/pkce/PkceAuthService.kt Outdated
): Credentials? {
return try {
val host = URL(oauth2.host).host
Log.d("Test OIDC -1 :: ", oauth2.clientId)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these test data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

gl-lovekesh
gl-lovekesh requested changes Jul 5, 2024
View reviewed changes
Copy link

@gl-lovekesh gl-lovekesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the unwanted code

@aman-alfresco aman-alfresco requested a review from gl-lovekesh July 5, 2024 07:46
@Alfresco Alfresco deleted a comment from aman-alfresco Jul 5, 2024
gl-lovekesh
gl-lovekesh approved these changes Jul 5, 2024
View reviewed changes
Copy link

@gl-lovekesh gl-lovekesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aman-alfresco aman-alfresco merged commit 3c88794 into main Jul 5, 2024
5 checks passed
@aman-alfresco aman-alfresco deleted the ADST-422 branch July 5, 2024 09:05
@aman-alfresco aman-alfresco restored the ADST-422 branch September 24, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gl-lovekesh gl-lovekesh gl-lovekesh approved these changes

@PiplaniVinay PiplaniVinay Awaiting requested review from PiplaniVinay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman-alfresco @gl-lovekesh @PiplaniVinay