Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Victoria Garcia - Ampers - API-Muncher #33

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Victoria Garcia - Ampers - API-Muncher #33

wants to merge 22 commits into from

Commits on May 4, 2018

  1. Created rails project with all gems I expect to need.

    @Lasiorhine
    Lasiorhine committed May 4, 2018
    Configuration menu
    Copy the full SHA
    62b26ef View commit details
    Browse the repository at this point in the history

Commits on May 5, 2018

  1. created basic framework for recipe controller, plus the template for … 

    …the API wrappee.
    @Lasiorhine
    Lasiorhine committed May 5, 2018
    Configuration menu
    Copy the full SHA
    08ecf08 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2018

  1. After extensive flailing, I am now getting a visible list of recipes … 

    …back from the API. So the Recipe and EdamamApiWrapper are woring now, with not-so-great routes and views, and a recipes controller I'm not at all sure about. But this is better than a sock in the eye.
    @Lasiorhine
    Lasiorhine committed May 6, 2018
    Configuration menu
    Copy the full SHA
    75e7db9 View commit details
    Browse the repository at this point in the history

  2. The images are coming through on the search okay, so now it's time to… 

    … make better routes and methods. Search and detail views added to recipes to facilitate this.
    @Lasiorhine
    Lasiorhine committed May 6, 2018
    Configuration menu
    Copy the full SHA
    549e50b View commit details
    Browse the repository at this point in the history

  3. Last commit was just views. This commit includes things that will sup… 

    …port the new views.
    @Lasiorhine
    Lasiorhine committed May 6, 2018
    Configuration menu
    Copy the full SHA
    2e1f014 View commit details
    Browse the repository at this point in the history

  4. tiny tweaks to the number of results obtained, and to the details met… 

    …hod in the recipe controller.
    @Lasiorhine
    Lasiorhine committed May 6, 2018
    Configuration menu
    Copy the full SHA
    78cdb20 View commit details
    Browse the repository at this point in the history

  5. all basic core functionality is here. Still needs CSS, heroku, and te… 

    …sts, but this is a solid start.
    @Lasiorhine
    Lasiorhine committed May 6, 2018
    Configuration menu
    Copy the full SHA
    254bdf0 View commit details
    Browse the repository at this point in the history

  6. will_paginate added, and CSS look and feel plan begun. Everything sti… 

    …ll a little goofy, but I don't think this is doomed anymore.
    @Lasiorhine
    Lasiorhine committed May 6, 2018
    Configuration menu
    Copy the full SHA
    42d8b80 View commit details
    Browse the repository at this point in the history

  7. Misc little tweaks, plus addition of the attribution thingee for Edamam.

    @Lasiorhine
    Lasiorhine committed May 6, 2018
    Configuration menu
    Copy the full SHA
    8adeade View commit details
    Browse the repository at this point in the history

Commits on May 7, 2018

  1. CSS is done and basically responsive. No actual media query, but that… 

    …'s too ambitious for this weekend, alas.
    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    52ea792 View commit details
    Browse the repository at this point in the history

  2. fixed some CSS for the index page.

    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    c65f3a9 View commit details
    Browse the repository at this point in the history

  3. tweaks to get the Heroku deployment to work.

    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    f0efcc6 View commit details
    Browse the repository at this point in the history

  4. made a change to config/application.rb in an attempt to get the Herok… 

    …u deployment to work.
    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    d930bf1 View commit details
    Browse the repository at this point in the history

  5. API wrapper tests all written and passing, after appropriate fails. A… 

    …lso, a few tweaks to the CSS, because having CSS means having to tweak it.
    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    63f521e View commit details
    Browse the repository at this point in the history

  6. All tests for the Recipe test are passing, after appropriate fails.

    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    6f35e68 View commit details
    Browse the repository at this point in the history

  7. all controller tests now passing after appropriate fails.

    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    bf2f870 View commit details
    Browse the repository at this point in the history

  8. A tiny try at getting flash messages to work. Not especially successful.

    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    1cc13c4 View commit details
    Browse the repository at this point in the history

  9. took out some 'require pry' stuff to get Heroku to work.

    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    9d27524 View commit details
    Browse the repository at this point in the history

  10. minor tweaks to make the flash messages work a little better.

    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    42f3720 View commit details
    Browse the repository at this point in the history

  11. very last little tweaks to make the flash alerts work.

    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    cf380b5 View commit details
    Browse the repository at this point in the history

  12. You know, it really helps to not have random 'raise'-es in your code … 

    …if you want it to work on an external server.
    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    3d5d9ea View commit details
    Browse the repository at this point in the history

  13. Commented out a broken assertion in the controller test, because this… 

    … is a surprise FAIL after pull request submission, and I don't have time to ask Chris and Dee about it, and the test is more-or-less valid without it.
    @Lasiorhine
    Lasiorhine committed May 7, 2018
    Configuration menu
    Copy the full SHA
    a6750e3 View commit details
    Browse the repository at this point in the history