forked from AdaGold/api-muncher
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Victoria Garcia - Ampers - API-Muncher #33
Open
Lasiorhine
wants to merge
22
commits into
Ada-C9:master
Choose a base branch
from
Lasiorhine:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…back from the API. So the Recipe and EdamamApiWrapper are woring now, with not-so-great routes and views, and a recipes controller I'm not at all sure about. But this is better than a sock in the eye.
… make better routes and methods. Search and detail views added to recipes to facilitate this.
…port the new views.
…hod in the recipe controller.
…sts, but this is a solid start.
…ll a little goofy, but I don't think this is doomed anymore.
…'s too ambitious for this weekend, alas.
…u deployment to work.
…lso, a few tweaks to the CSS, because having CSS means having to tweak it.
…if you want it to work on an external server.
… is a surprise FAIL after pull request submission, and I don't have time to ask Chris and Dee about it, and the test is more-or-less valid without it.
API MuncherWhat We're Looking For
|
CheezItMan
reviewed
May 8, 2018
describe Recipe do | ||
|
||
it "can be initialized" do | ||
test_recipe = Recipe.new( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also have tests for the wrong # of arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions
After spending lots of time poring over Edamam's own docs, I spent another large block of time poking at the API with Postman. Without Postman, I would have been totally lost.
Describe your API Wrapper. How did you decide on the methods you created? |
My API wrapper has two methods: one for getting search results and one for retrieving information about a specific recipe. I chose these because, well, that's what the assignment specified.
Describe an edge case or failure case test you wrote for your API Wrapper. |
For the recipe detail function, I wrote tests for if users try to key in an exogenous URI, instead of just clicking the button and sending a get request with the URI of one of the recipes displayed on the site.
Explain how VCR aids in testing an API. |
It creates a little pen in which you can test the behavior of your code against pre-recorded responses to previous API calls. That way, you don't have to make a fresh API call for every test you run.
What is the Heroku URL of your deployed application? |
https://victualizer.herokuapp.com/
Provide a link to the Trello board you used |
https://trello.com/b/jEnZutpQ/api-muncher