Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor person to contact #27

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix style errors
CJ-Lee01 committed Oct 5, 2023
commit c7f19464fb3e16f11d8f589eff8b67e18853e478
2 changes: 1 addition & 1 deletion src/main/java/seedu/address/model/AddressBook.java
Original file line number Diff line number Diff line change
@@ -78,7 +78,7 @@ public void addPerson(Contact p) {
/**
* Replaces the given contact {@code target} in the list with {@code editedContact}.
* {@code target} must exist in the address book.
* The contact identity of {@code editedContact} must not be the same as another existing contact in the address book.
* The contact identity of {@code editedContact} must not be the same as another existing one in the address book.
*/
public void setPerson(Contact target, Contact editedContact) {
requireNonNull(editedContact);
2 changes: 1 addition & 1 deletion src/main/java/seedu/address/model/Model.java
Original file line number Diff line number Diff line change
@@ -72,7 +72,7 @@ public interface Model {
/**
* Replaces the given contact {@code target} with {@code editedContact}.
* {@code target} must exist in the address book.
* The contact identity of {@code editedContact} must not be the same as another existing contact in the address book.
* The contact identity of {@code editedContact} must not be the same as another existing one in the address book.
*/
void setPerson(Contact target, Contact editedContact);

1 change: 0 additions & 1 deletion src/main/java/seedu/address/model/ReadOnlyAddressBook.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package seedu.address.model;

import javafx.collections.ObservableList;

import seedu.address.model.person.Contact;

/**
Original file line number Diff line number Diff line change
@@ -13,8 +13,8 @@

/**
* A list of persons that enforces uniqueness between its elements and does not allow nulls.
* A contact is considered unique by comparing using {@code Contact#isSamePerson(Contact)}. As such, adding and updating of
* persons uses Contact#isSamePerson(Contact) for equality so as to ensure that the contact being added or updated is
* A contact is considered unique by comparing using {@code Contact#isSamePerson(Contact)}. As such, adding and updating
* of persons uses Contact#isSamePerson(Contact) for equality so as to ensure that the contact being added or updated is
* unique in terms of identity in the UniquePersonList. However, the removal of a contact uses Contact#equals(Object) so
* as to ensure that the contact with exactly the same fields will be removed.
*
1 change: 0 additions & 1 deletion src/main/java/seedu/address/ui/PersonCard.java
Original file line number Diff line number Diff line change
@@ -7,7 +7,6 @@
import javafx.scene.layout.FlowPane;
import javafx.scene.layout.HBox;
import javafx.scene.layout.Region;

import seedu.address.model.person.Contact;

/**