Refactor person to contact #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJ-Lee01
added
the
type.Chore
CJ-Lee01
requested review from
a team,
McNaBry and
wamps-jp
and removed request for
a team
|
It appears that the JsonSerializableAddressBook class cannot be refactored without breaking a lot of things. |
I believe this is because that class (and other similar ones) functions as the interface between the final JSON file stored and the internal models, converting to and from via Jackson. Since many tests use template JSON files to verify JSON Serializable class behaviors, all JSON test cases must be manually modified and likely cannot be automatically refactored by the IDE. |
McNaBry
approved these changes
Oct 7, 2023
wamps-jp
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated a few test cases and documentation to reflect the change and changed
toStringmethod to pass test cases.