Hide snapshots in case no vm associated #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goarsna
force-pushed
the
Hide_snapshots_in_case_no_VM_associated
branch
from
f421fd8 to
1b236ff
Compare
sbernhard
reviewed
Sep 15, 2023
webpack/components/SnapshotManagementCard/SnapshotManagementCard.js
Outdated
Show resolved
Hide resolved
goarsna
force-pushed
the
Hide_snapshots_in_case_no_VM_associated
branch
from
1b236ff to
cb0aa87
Compare
goarsna
force-pushed
the
Hide_snapshots_in_case_no_VM_associated
branch
from
cb0aa87 to
1274368
Compare
sbernhard
previously approved these changes
Nov 17, 2023
m-bucher
requested changes
Nov 17, 2023
There was a problem hiding this comment.
by the way, we should fix the tests. :-)
Indeed we should 😅
@goarsna please add a uuid to the mocked hostDetails-struct, here to fix the tests:
goarsna
force-pushed
the
Hide_snapshots_in_case_no_VM_associated
branch
from
cc5ddbe to
633a3a1
Compare
goarsna
force-pushed
the
Hide_snapshots_in_case_no_VM_associated
branch
from
53a07ea to
4f8cf69
Compare
m-bucher
approved these changes
Dec 5, 2023
|
Since the remaining test-failures are npm-dependency issues on outdated foreman versions, I am OK with merging this. We should groom our test-cases soon 😅 |
sbernhard
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.