Hide snapshots in case UUID is not set

ATIX-AG · Sep 18, 2023 · cb0aa87 · cb0aa87
1 parent c2d3795
commit cb0aa87
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/lib/foreman_snapshot_management/engine.rb b/lib/foreman_snapshot_management/engine.rb
@@ -63,7 +63,7 @@ class Engine < ::Rails::Engine
           context.add_pagelet :main_tabs,
                               :name => N_('Snapshots'),
                               :partial => 'hosts/snapshots_tab',
-                              :onlyif => proc { |host| host&.compute_resource&.capable?(:snapshots) }
+                              :onlyif => proc { |host| host&.uuid.present? && host&.compute_resource&.capable?(:snapshots) }
         end
       end
     end

diff --git a/webpack/components/SnapshotManagementCard/SnapshotManagementCard.js b/webpack/components/SnapshotManagementCard/SnapshotManagementCard.js
@@ -18,7 +18,7 @@ const SnapshotManagementCard = ({ hostDetails, ...props }) => {
       hostDetails?.capabilities?.includes('snapshot_include_quiesce') || false,
   };
 
-  if (hostDetails?.id && hostDetails?.permissions)
+  if (hostDetails?.uuid && hostDetails?.id && hostDetails?.permissions) {
     children.push(
       <SnapshotManagement
         key="SnapshotManagement"
@@ -30,14 +30,17 @@ const SnapshotManagementCard = ({ hostDetails, ...props }) => {
         capabilities={capabilities}
       />
     );
-  return (
-    <CardTemplate
-      overrideGridProps={{ xl2: 6, xl: 8, lg: 8, md: 12 }}
-      header={__('Snapshots')}
-    >
-      {children}
-    </CardTemplate>
-  );
+    return (
+      <CardTemplate
+        overrideGridProps={{ xl2: 6, xl: 8, lg: 8, md: 12 }}
+        header={__('Snapshots')}
+      >
+        {children}
+      </CardTemplate>
+    );
+  }
+  else 
+    return null;
 };
 
 export default SnapshotManagementCard;
@@ -46,6 +49,7 @@ SnapshotManagementCard.propTypes = {
   hostDetails: PropTypes.shape({
     name: PropTypes.string,
     id: PropTypes.number,
+    uuid: PropTypes.string,
     capabilities: PropTypes.array,
     permissions: PropTypes.shape({
       create_snapshots: PropTypes.bool,