Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify low mass convective star #52

Closed

Conversation

zingale
Copy link
Member

@zingale zingale commented Aug 27, 2023

No description provided.

@zingale
Copy link
Member Author

zingale commented Aug 27, 2023

for some reason, this gives rather large diffs compared to the original version, even though they should be the same to tolerances.

@zingale
Copy link
Member Author

zingale commented Jun 18, 2024

I think that the reason this fails is that doing eos_input_ps is only doing the root finding on the thermodynamics / EOS part. It does not account for the fact that changing rho also changes HSE. For this setup, we seem to be very sensitive to that, and if we just use the EOS to zero things, then we get convergence on the thermodynamics without then having to adjust the dynamics, it seems.

So I think that the correct way to do this is as implemented.

It also suggests that for the other problems, we should be doing the same thing and not relying on eos_input_ps

@zingale zingale closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant