Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: units pm and mm missing from spm_pixel_to_nm_scaling #84

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

SylviaWhittle
Copy link
Collaborator

Closes #83

Adds the same units dictionary that was used in TopoStats to AFMReader. Apologies, I somehow omitted the units pm and mm from when I copied the code over.

@SylviaWhittle SylviaWhittle self-assigned this Dec 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.81%. Comparing base (f282c31) to head (1821f51).
Report is 198 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   65.87%   71.81%   +5.94%     
==========================================
  Files           3        8       +5     
  Lines         337      589     +252     
==========================================
+ Hits          222      423     +201     
- Misses        115      166      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 quick work.

The only thing I can think of is whether we have tests in place to ensure these units are handled and also correctly handle unsupported units (e.g. cm or m and I mention the later because @tcatley pull request to report the mean width suggests the unit this is returned in is metres, see line 276 of Pull Request #999)

@SylviaWhittle SylviaWhittle merged commit 7483dda into main Dec 5, 2024
13 checks passed
@SylviaWhittle SylviaWhittle deleted the SylviaWhittle/hotfix-spm-units branch December 5, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AFMReader SPM module unable to handle common units
3 participants