Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate IO class from TopoStats #22

Closed
8 tasks done
ns-rse opened this issue Dec 7, 2023 · 4 comments
Closed
8 tasks done

Migrate IO class from TopoStats #22

ns-rse opened this issue Dec 7, 2023 · 4 comments
Labels
topostats Migration of functionality from TopoStats

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Dec 7, 2023 •
edited
Loading

We should migrate the functionality in the topostats.io.LoadScan class from TopoStats to topofileformats AFMReader.

This will supersede issues #1 , #16 and #17 which are all file formats that are currently supported by TopoStats.

The migration should be done in two stages...

  • Firstly copy the class and methods over to topofileformats `AFMReader along with tests and ensure that the functionality works as a stand alone aspect of this package.
    • .asd (in-progress see comment below)
    • .ibw
    • .gwy (in-progress, PR due soon 2024-05-07).
    • .jpk
    • `.spm
    • .topostats
  • Remove the use of topostats.io.LoadScan from TopoStats and instead import the class from topofileformats.io.LoadScan AFMReader.io.LoadScan.

Another thing to consider is to integrate the current .asd support into the migrated class and make it a method
available in the LoadScan class.
@ns-rse ns-rse added the topostats Migration of functionality from TopoStats label Dec 7, 2023
@SylviaWhittle
Copy link
Collaborator

Update: .jpk, .ibw, .spm have been added. .gwy needs adding and .asd needs a fix I'm adding soon.

@SylviaWhittle SylviaWhittle mentioned this issue May 14, 2024
Merged
@ns-rse ns-rse mentioned this issue May 29, 2024
Closed
10 tasks
@SylviaWhittle
Copy link
Collaborator

Update: Added .topostats format as of #53

@SylviaWhittle
Copy link
Collaborator

Update: Gwy migrated as of #61

@ns-rse
Copy link
Collaborator Author

ns-rse commented Dec 16, 2024

We have now migrated to using AFMReader in TopoStats, see recent commits #79, #84 and #87 and in TopoStats issue
#1031.

@ns-rse ns-rse closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topostats Migration of functionality from TopoStats
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ns-rse @SylviaWhittle