-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add biome #76
chore: Add biome #76
Conversation
Biome looks cool, but with Eslint and Prettier, both being supported and used by @hey-api/open API-ts. I would suggest we use those as I do not believe Biome to be such a benefit to lose out on compatibility checks. Maybe we can use biome for the root of the project and prettier/eslint for a specific test project but also why bother to do so. |
@seriouslag |
chore: Add snapshot tests
I understand what you are saying and disagree with it, as I do not feel this is the same as you are saying. We do not have to follow their same linting rules or anything. I do not understand why we would deviate, it seems arbitrary to want to use a non-industry standard linter/formatter. I see no benefit in using biome over eslint/prettier, when we have a clear benefit with the other way around. |
Indeed, you are right. I hadn't noticed that there is a new format option. I will close this PR. |
https://biomejs.dev/