Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add biome #76

Closed
wants to merge 6 commits into from
Closed

chore: Add biome #76

wants to merge 6 commits into from

Conversation

7nohe
Copy link
Owner

@7nohe 7nohe commented Apr 20, 2024

  • Use Biome to lint and format code
  • Run Biome on CI (only on ubuntu-latest)
  • Run Biome at pre-commit
  • Upgrade pnpm to v9

https://biomejs.dev/

@7nohe 7nohe requested a review from seriouslag April 20, 2024 09:56
@7nohe 7nohe self-assigned this Apr 20, 2024
@seriouslag
Copy link
Collaborator

Biome looks cool, but with Eslint and Prettier, both being supported and used by @hey-api/open API-ts.

I would suggest we use those as I do not believe Biome to be such a benefit to lose out on compatibility checks. Maybe we can use biome for the root of the project and prettier/eslint for a specific test project but also why bother to do so.

@seriouslag seriouslag added the enhancement New feature or request label Apr 20, 2024
@7nohe
Copy link
Owner Author

7nohe commented Apr 20, 2024

@seriouslag
Although this project depends on @hey-api/openapi-ts, I feel that linters and formatters are not very relevant. Moreover, managing plugins and rule settings with two separate packages, Prettier and ESLint, can be complex, so I would like to choose an option that is as simple and modern as possible.

@seriouslag
Copy link
Collaborator

seriouslag commented Apr 20, 2024

@seriouslag Although this project depends on @hey-api/openapi-ts, I feel that linters and formatters are not very relevant. Moreover, managing plugins and rule settings with two separate packages, Prettier and ESLint, can be complex, so I would like to choose an option that is as simple and modern as possible.

I understand what you are saying and disagree with it, as I do not feel this is the same as you are saying.
We allow users to pass in options invoking the prettier/eslint config to run in the underlying tool.
Being a wrapper and extension of the said package, I feel we should use the same tooling.

We do not have to follow their same linting rules or anything. I do not understand why we would deviate, it seems arbitrary to want to use a non-industry standard linter/formatter.

I see no benefit in using biome over eslint/prettier, when we have a clear benefit with the other way around.

@7nohe
Copy link
Owner Author

7nohe commented Apr 20, 2024

Indeed, you are right. I hadn't noticed that there is a new format option. I will close this PR.
I've been seeing a trend of switching to Biome around me, so I thought it would be good to adopt it. It might be a good idea to suggest Biome for the @hey-api/openapi-ts project as well

@7nohe 7nohe closed this Apr 20, 2024
@7nohe 7nohe deleted the chore/biome branch April 20, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants