fix(hooks): generate other https methods #74
Conversation
Before this patch, only GET queries and POST mutations were created. We now generate mutation hooks for PUT, PATCH, and DELETE
prettier was replacing the quotes with double quotes causing th checks to break.
seriouslag
force-pushed
the
hooks/generate-other-http-methods
branch
from
6267a8b to
3e89bf5
Compare
|
Released a test version with this patch under: @seriouslag/openapi-react-query-codegen@next |
| @@ -16,6 +16,7 @@ | |||
| "@tanstack/react-query": "^5.18.1", | |||
| "axios": "^1.6.7", | |||
| "form-data": "~4.0.0", | |||
| "prettier": "^3.2.5", | |||
There was a problem hiding this comment.
Is this package necessary for this modification? I am considering Biome as a tool for linting and formatting in terms of performance and ease of implementation.
There was a problem hiding this comment.
This is needed as a test for users of the repo, as described.
Prettier and eslint are used for the underlying @hey-api/openapi-ts, don't know why we would use biome over those tools.
There was a problem hiding this comment.
I see. I just ran it again and indeed confirmed that Prettier is working. This is fine as it is.
However, I believe that the generated code should not be changed depending on whether Prettier is installed or not. Therefore, it might be a good idea to add comments like eslint-disable to the generated code, similar to what was done with the previous openapi-typescript-codegen.
There was a problem hiding this comment.
Agreed, adding that would be good in my opinion.
Before this patch, only GET queries and POST mutations were created.
We now generate mutation hooks for PUT, PATCH, and DELETE
This patch also fixes an issue where if prettier was installed, it would format the generated service files, changing the quotes around and breaking our checks to determine the HTTP method type.
Example before prettier:
'GET'Example after prettier:
"GET"The prettier style of writing functionality was added by the underlying service file generator @hey-api/openapi-ts
I updated the checks to not care about quotes.
Added
prettieras a dependency of the example app so that prettier will now run on the generated service files to act as a test for that feature.fixes: #70
fixes: #75