Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hooks): generate other https methods #74

Merged
merged 3 commits into from
Apr 20, 2024
Merged

fix(hooks): generate other https methods #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1234434
fix(hooks): generate other https methods
seriouslag Apr 17, 2024
745912e
fix: fix formatted code generated
seriouslag Apr 19, 2024
3e89bf5
chore: add prettier to test prettier functionality
seriouslag Apr 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"@tanstack/react-query": "^5.18.1",
"axios": "^1.6.7",
"form-data": "~4.0.0",
"prettier": "^3.2.5",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this package necessary for this modification? I am considering Biome as a tool for linting and formatting in terms of performance and ease of implementation.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the PR #76.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed as a test for users of the repo, as described.
Prettier and eslint are used for the underlying @hey-api/openapi-ts, don't know why we would use biome over those tools.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I just ran it again and indeed confirmed that Prettier is working. This is fine as it is.
However, I believe that the generated code should not be changed depending on whether Prettier is installed or not. Therefore, it might be a good idea to add comments like eslint-disable to the generated code, similar to what was done with the previous openapi-typescript-codegen.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, adding that would be good in my opinion.

"react": "^18.2.0",
"react-dom": "^18.2.0"
},
Expand Down
Loading