-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: instant feedback for reaching max character limit in input fields #169
base: main
Are you sure you want to change the base?
Conversation
This makes the description, comment and contact input fields all the same. Now that the max length is visible as a counter, it would be confusing why one they are different lengths. 4096 is chosen because Discord seems to limit the amount of characters to 4096.
run-prettier |
Given that the input fields automatically resize with the amount of text inside them, the scrollbars are not really necessary anymore and looked outdated. Removing the resizing option would only serve to make the input field smaller, which is not really useful. Both of these changes make the input fields just a bit cleaner.
I tried to merge with main to resolve the conflicts, but in the end I gave up :// Maybe if we could split the changes in 3 different PRs? |
@ifaoji said a rework of improvements related to this PR is already in work. But I have no idea what's the state of it. |
I think the only way to save this PR is to sit together for an hour, |
Yes, but I don't have time rn to finish it. In ~1-2 weeks I'll have some free time. for it |
This makes the description, comment and contact input fields all the same.
Now that the max length is visible as a counter, it would be confusing why they are different lengths.
4096 is chosen because Discord seems to limit the amount of characters to 4096.
Given that the input fields automatically resize with the amount of text inside them, the scrollbars are not really necessary anymore and looked outdated.
Removing the resizing option would only serve to make the input field smaller, which is not really useful.
Both of these changes make the input fields just a bit cleaner.