Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: instant feedback for reaching max character limit in input fields #169

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

itislu
Copy link
Collaborator

@itislu itislu commented Sep 4, 2024

image


  • Input fields also increase in height automatically now when visible area is completely filled.

image


  • Standardize large text input fields to 4096 max length.

This makes the description, comment and contact input fields all the same.
Now that the max length is visible as a counter, it would be confusing why they are different lengths.
4096 is chosen because Discord seems to limit the amount of characters to 4096.


  • Remove scrollbar and resizing from input fields.

Given that the input fields automatically resize with the amount of text inside them, the scrollbars are not really necessary anymore and looked outdated.
Removing the resizing option would only serve to make the input field smaller, which is not really useful.
Both of these changes make the input fields just a bit cleaner.

image

@itislu
Copy link
Collaborator Author

itislu commented Sep 4, 2024

run-prettier

github-actions bot and others added 3 commits September 4, 2024 16:49
Given that the input fields automatically resize with the amount of text inside them, the scrollbars are not really necessary anymore and looked outdated.

Removing the resizing option would only serve to make the input field smaller, which is not really useful.

Both of these changes make the input fields just a bit cleaner.
@leeoocca
Copy link
Member

I tried to merge with main to resolve the conflicts, but in the end I gave up ://

Maybe if we could split the changes in 3 different PRs?

@itislu
Copy link
Collaborator Author

itislu commented Oct 28, 2024

@ifaoji said a rework of improvements related to this PR is already in work. But I have no idea what's the state of it.
I think first we should clarify that before putting any more work into this PR.

@itislu
Copy link
Collaborator Author

itislu commented Oct 29, 2024

I think the only way to save this PR is to sit together for an hour, git rebase and solve the conflicts commit by commit.

@ifaoji
Copy link
Member

ifaoji commented Oct 29, 2024

@ifaoji said a rework of improvements related to this PR is already in work. But I have no idea what's the state of it. I think first we should clarify that before putting any more work into this PR.

Yes, but I don't have time rn to finish it. In ~1-2 weeks I'll have some free time. for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants