Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the website actually look good #141

Open
9 of 22 tasks
ifaoji opened this issue Aug 26, 2024 · 3 comments
Open
9 of 22 tasks

Make the website actually look good #141

ifaoji opened this issue Aug 26, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ifaoji
Copy link
Member

ifaoji commented Aug 26, 2024

Currently the Website does not really look that good. We should change that.

To-Do:

@leeoocca
Copy link
Member

Some vague ideas:

  • Login page
    • Create a card to mimic traditional login prompts
    • "Sign in with 42"
  • Home
    • Really necessary? Would link directly to Open Issues, show some stats or maybe announcements from the council, or list possible actions for the user (kind of a sitemap)
  • Footer
    • Is invisible unless you unintentionally scroll down. I like sticky footers but they're hard to see if they are outside of the viewport
  • Issues
    • Remove outer card as it's the main content of the page, no other elements to distinguish it from
    • Maybe move the total votes to the left of the title, more similar to Reddit or HN. Currently you have to follow with the eye all the way to the middle of the page making it harder to scan quickly
    • Open/Archived state is not saved during navigation: opening an issue under Archived and going back, navigates to Open Issues
    • Move Open/Archived under page Title+Description
    • Button text to "Open an issue"
  • Issue #N
    • Main title should be Issue title, with issue number as additional information i.e. here on GitHub
    • Make text size consistent between issue description and comments
    • "Go back" button with less important color and aligned on the left
    • Put likes value outside of button or reduce the text inside. Currently the value is hard to scan
    • Reduce page width to around 90ch (setting max-width: 90ch already works great, actually could be a good measure for other pages as well)
    • Maybe hide detailed description about how you save the likes under a details, with a simple summary like "Upvotes are not anonymous"
    • Comments
      • Style dates consistently with /issues, remove "on"
      • Align date bottom right
      • Lighter background color for each card
    • Mark archived issues as such (just a simple badge)
    • Link to Student Council answer close to initial Issue description
  • Other pages
    • Usually the hr after the h1 feels unnecessary and repetitive as there's another line with exactly the same style just above it

Enough for now 😅

@ifaoji
Copy link
Member Author

ifaoji commented Aug 27, 2024

Thank you for the many ideas Leo 👏
I will add them as a To-Do list to the Issue 🫡

@itislu itislu added the enhancement New feature or request label Aug 28, 2024
ifaoji added a commit that referenced this issue Aug 28, 2024
As pointed out in #141 separators after a title are unnecessary.
itislu pushed a commit that referenced this issue Aug 28, 2024
As pointed out in #141 separators after a title are unnecessary.
@leeoocca
Copy link
Member

Another idea regarding opening issues and possibly adding comments:

  • textarea should resize automatically to fit all text, avoiding scrollbars i.e. what GitHub and most other modern websites do. Scrollbars are generally not great, especially on mobile, as they conceal text outside of the viewport...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants