-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some docs fixes #395
Merged
Merged
Some docs fixes #395
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,11 +34,12 @@ doc](./async.md). | |
### Redis databases | ||
|
||
The standard 3scale deployment uses a single Redis pod and sets both the resque | ||
DB and the data DB in the same Redis process under different DB indexes. This is | ||
not supported by the async redis library, so we need to either place both DBs in | ||
the same Redis process or use two separate ones. To configure this, change the | ||
`CONFIG_REDIS_PROXY` and `REDIS_QUEUES_URL` envs in the listener and worker | ||
deployment configs. | ||
DB and the data DB in the same Redis process under different DB indexes. If an | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change was mainly to fix the statement that DB indexes are not supported in async redis library. This feature was added here: #390 |
||
external Redis is used the URLs set in `CONFIG_REDIS_PROXY` and | ||
`CONFIG_QUEUES_MASTER_NAME` can be configured to either two separate Redis instances | ||
(e.g. `redis://backend-queues.example.com:6379` and `redis://backend-storage.example.com:6379`), | ||
or a single Redis instance with separate databases (e.g. `redis://backend.example.com:6379/0` | ||
and `redis://backend.example.com:6379/1`). | ||
|
||
### Enable async | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these ones were swapped...
CONFIG_REDIS_PROXY
is for storage, andCONFIG_QUEUES_MASTER_NAME
is for Resque