-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some docs fixes #395
Some docs fixes #395
Conversation
of where the Redis Resque has been installed | ||
* CONFIG_REDIS_PROXY: Set this to the [`redis://` URL](http://www.iana.org/assignments/uri-schemes/prov/redis) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these ones were swapped... CONFIG_REDIS_PROXY
is for storage, and CONFIG_QUEUES_MASTER_NAME
is for Resque
the same Redis process or use two separate ones. To configure this, change the | ||
`CONFIG_REDIS_PROXY` and `REDIS_QUEUES_URL` envs in the listener and worker | ||
deployment configs. | ||
DB and the data DB in the same Redis process under different DB indexes. If an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was mainly to fix the statement that DB indexes are not supported in async redis library. This feature was added here: #390
docs/openshift_horizontal_scaling.md
Outdated
deployment configs. | ||
DB and the data DB in the same Redis process under different DB indexes. If an | ||
external Redis is used the URLs set in `CONFIG_REDIS_PROXY` and | ||
`REDIS_QUEUES_URL` can be configured to either two separate Redis instances |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what's REDIS_QUEUES_URL
for, I don't think apisonator uses it. Shouldn't it be CONFIG_QUEUES_MASTER_NAME
?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right, apisonator uses CONFIG_QUEUES_MASTER_NAME
environment variable. I didn't check the original env vars, but there was a mix of what apisonator uses, and what operator uses 🙃
Here is the mapping:
"backend-redis" secret | apisonator env var |
---|---|
REDIS_STORAGE_URL | CONFIG_REDIS_PROXY |
REDIS_STORAGE_SENTINEL_HOSTS | CONFIG_REDIS_SENTINEL_HOSTS |
REDIS_STORAGE_SENTINEL_ROLE | CONFIG_REDIS_SENTINEL_ROLE |
REDIS_QUEUES_URL | CONFIG_QUEUES_MASTER_NAME |
REDIS_QUEUES_SENTINEL_HOSTS | CONFIG_QUEUES_SENTINEL_HOSTS |
REDIS_QUEUES_SENTINEL_ROLE | CONFIG_QUEUES_SENTINEL_ROLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've amended this env var name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know the operator uses different variables. Thanks for the info.
05593aa
to
c37a2d8
Compare
Just fixing some internal docs.