Google Search: Allow extracting items from SERP results #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmike
reviewed
Nov 7, 2024
wRAR
approved these changes
Nov 12, 2024
kmike
reviewed
Nov 12, 2024
kmike
reviewed
Nov 12, 2024
kmike
reviewed
Nov 12, 2024
| @@ -58,6 +124,7 @@ class GoogleDomainParam(BaseModel): | |||
|
|
|||
| class GoogleSearchSpiderParams( | |||
| MaxRequestsParam, | |||
| SerpItemTypeParam, | |||
There was a problem hiding this comment.
Should we provide extract_from option, which applies only for the items extracted from the linked websites, not to search results extraction itself?
There was a problem hiding this comment.
Doesn't need to be in the same PR though.
We also should add custom attributes extraction, probably also separately.
|
The implementation looks good to me. |
kmike
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do: