Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword param descriptions. #65

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Reword param descriptions. #65

merged 3 commits into from
Oct 15, 2024

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Sep 9, 2024

No description provided.

@wRAR wRAR marked this pull request as draft September 9, 2024 12:12
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.14%. Comparing base (d01ac8d) to head (954dd3d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files          16       16           
  Lines         946      946           
=======================================
  Hits          919      919           
  Misses         27       27           
Files with missing lines Coverage Δ
zyte_spider_templates/params.py 96.63% <100.00%> (ø)
zyte_spider_templates/spiders/ecommerce.py 97.39% <100.00%> (ø)

@wRAR wRAR marked this pull request as ready for review October 11, 2024 10:07
@wRAR wRAR marked this pull request as draft October 11, 2024 10:12
@wRAR wRAR marked this pull request as ready for review October 11, 2024 10:14
@kmike kmike merged commit 19f3a45 into main Oct 15, 2024
12 checks passed
@wRAR wRAR deleted the param-descrs branch October 18, 2024 07:24
wRAR pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants