Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page_objects → pages #19

Merged
merged 3 commits into from
Dec 15, 2023
Merged

page_objects → pages #19

merged 3 commits into from
Dec 15, 2023

Conversation

Gallaecio
Copy link
Contributor

@Gallaecio Gallaecio commented Dec 14, 2023

To-do:

  • Maintain backward compatibility.

@Gallaecio Gallaecio requested review from kmike, wRAR and BurnzZ December 14, 2023 12:41
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Merging #19 (ceb4a10) into main (7b13d62) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head ceb4a10 differs from pull request most recent head e811fa4. Consider uploading reports for the commit e811fa4 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   98.39%   98.40%   +0.01%     
==========================================
  Files           9       11       +2     
  Lines         498      502       +4     
==========================================
+ Hits          490      494       +4     
  Misses          8        8              
Files Coverage Δ
zyte_spider_templates/page_objects/__init__.py 100.00% <100.00%> (ø)
...ates/page_objects/product_navigation_heuristics.py 100.00% <100.00%> (ø)
zyte_spider_templates/pages/__init__.py 100.00% <100.00%> (ø)
...r_templates/pages/product_navigation_heuristics.py 100.00% <100.00%> (ø)

@Gallaecio
Copy link
Contributor Author

Sorry to bother you again, but please review e811fa4 as well, just to be sure before I merge.

@Gallaecio Gallaecio requested review from kmike, BurnzZ and wRAR December 14, 2023 14:35
@Gallaecio Gallaecio merged commit d7e9c15 into zytedata:main Dec 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants