Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI fails #762

Merged
merged 1 commit into from
Dec 1, 2024
Merged

fix CI fails #762

merged 1 commit into from
Dec 1, 2024

Conversation

jokester
Copy link
Contributor

@jokester jokester commented Dec 1, 2024

  • pin httpx: v0.28.0 removed AsyncClient(proxies=) option, breaking tests like
test/test_translation.py:47: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
manga_translator/translators/__init__.py:100: in dispatch
    translator = get_translator(key)
manga_translator/translators/__init__.py:65: in get_translator
    translator_cache[key] = translator(*args, **kwargs)
manga_translator/translators/chatgpt.py:60: in __init__
    self.client = openai.AsyncOpenAI(api_key = openai.api_key or OPENAI_API_KEY)
venv/lib/python3.10/site-packages/openai/_client.py:334: in __init__
    super().__init__(
venv/lib/python3.10/site-packages/openai/_base_client.py:1421: in __init__
    self._client = http_client or AsyncHttpxClientWrapper(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <openai._base_client.AsyncHttpxClientWrapper object at 0x7f64651034f0>
kwargs = {'base_url': 'https://api.openai.com/v1', 'follow_redirects': True, 'limits': Limits(max_connections=1000, max_keepalive_connections=100, keepalive_expiry=5.0), 'proxies': None, ...}

    def __init__(self, **kwargs: Any) -> None:
        kwargs.setdefault("timeout", DEFAULT_TIMEOUT)
        kwargs.setdefault("limits", DEFAULT_CONNECTION_LIMITS)
        kwargs.setdefault("follow_redirects", True)
>       super().__init__(**kwargs)
E       TypeError: AsyncClient.__init__() got an unexpected keyword argument 'proxies'

@jokester jokester marked this pull request as ready for review December 1, 2024 07:58
@zyddnys zyddnys merged commit 25bc252 into zyddnys:main Dec 1, 2024
2 checks passed
@jokester jokester deleted the fix-dep-fails branch December 2, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants