fix overflow in SegDetectorRepresenter and get_transformed_region #704
+65
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this image of 1280x45890, all detectors failed because of some post-processing overflow and OCR also failed due to the overflow in cv2.warpPerspective. This PR fixes it so the text in this image can be detected and recognized like an image with normal size.
But upon saving the result
manga-image-translator/manga_translator/utils/generic.py
Line 274 in ead6693
could potentially eat up all memory, I have to close some programs to get it done on my win11 laptop with 32GB, but I'll leave the optimization to others.
Test case:
https://github.com/user-attachments/assets/4b22b2d9-d2f0-402f-80d2-5cc6b7c0db0f