Update requirements.txt #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy got updated to 2.0 and py3landid added support for numpy 2.0. Try the below, and it should work; it did for me. pip install py3landid==0.2.2 pip install numpy==1.23.5
|
why did you remove pydensecrf and langdetect? |
jokester
added a commit
to moeflow-com/manga-image-translator
that referenced
this pull request
Jul 3, 2024
a recent version is necessary after zyddnys#645 but it got incorrected downgraded in zyddnys#657
jokester
added a commit
to moeflow-com/manga-image-translator
that referenced
this pull request
Jul 3, 2024
a recent version is necessary after zyddnys#645 but it got incorrectly downgraded in zyddnys#657
|
The numpy change was valid but pydencerf and openai should not really be touched. The old openai==0.28.0 breaks after #645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy got updated to 2.0 and py3landid added support for numpy 2.0. Try the below, and it should work; it did for me.
pip install py3landid==0.2.2
pip install numpy==1.23.5