Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce predicted instruction size (Fixes #478) #479

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Enforce predicted instruction size (Fixes #478) #479

merged 1 commit into from
Feb 4, 2024

Conversation

mappzor
Copy link
Contributor

@mappzor mappzor commented Jan 26, 2024

Fixes #478

flobernd
flobernd approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side. Thank you 🙂

@flobernd flobernd requested a review from athre0z January 26, 2024 08:32
athre0z
athre0z approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@athre0z athre0z merged commit 4a151f8 into zyantific:master Feb 4, 2024
13 checks passed
@mappzor mappzor deleted the abs_ranges branch February 4, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flobernd flobernd flobernd approved these changes

@athre0z athre0z athre0z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encoder fails to enforce predicted instruction size in some scenarios
3 participants
@mappzor @athre0z @flobernd