Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Quantomatic links to zxcalc. #324

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Rename Quantomatic links to zxcalc. #324

merged 2 commits into from
Jul 15, 2024

Conversation

dlyongemallo
Copy link
Contributor

No description provided.

@dlyongemallo dlyongemallo marked this pull request as draft July 12, 2024 16:16
@dlyongemallo dlyongemallo force-pushed the rename_quantomatic_zxcalc branch from fc540db to 9dbe1bb Compare July 14, 2024 17:56
@dlyongemallo dlyongemallo marked this pull request as ready for review July 14, 2024 17:57
@boldar99
Copy link
Collaborator

boldar99 commented Jul 15, 2024 •
edited
Loading

Maybe the value of myappid can also be changed to use zxcalc instead of quantomatic.

https://github.com/dlyongemallo/zxlive/blob/9dbe1bb1203c899cd49bb014be328961658098fb/zxlive/app.py#L35

@dlyongemallo
Copy link
Contributor Author

Maybe the value of myappid can also be changed to use zxcalc instead of quantomatic.

https://github.com/dlyongemallo/zxlive/blob/9dbe1bb1203c899cd49bb014be328961658098fb/zxlive/app.py#L35

Done.

boldar99
boldar99 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@boldar99 boldar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvdwetering jvdwetering merged commit 446f4c4 into zxcalc:master Jul 15, 2024
2 checks passed
@dlyongemallo dlyongemallo deleted the rename_quantomatic_zxcalc branch July 19, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boldar99 boldar99 boldar99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlyongemallo @boldar99 @jvdwetering