Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollup not working on arm #4018

Merged
merged 7 commits into from
Nov 19, 2024
Merged

fix: rollup not working on arm #4018

merged 7 commits into from
Nov 19, 2024

Conversation

robertsLando
Copy link
Member

Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to at least run an npm install to have the lockfile updated.

@coveralls
Copy link

coveralls commented Nov 19, 2024

Pull Request Test Coverage Report for Build 11913397084

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.069%

Totals Coverage Status
Change from base Build 11897033710: 0.0%
Covered Lines: 3946
Relevant Lines: 19918

💛 - Coveralls

@robertsLando
Copy link
Member Author

@AlCalzone I dropped package-lock and run npm i and nothing changed on lock file 🤷🏼‍♂️

@AlCalzone
Copy link
Member

This isn't working

@AlCalzone AlCalzone closed this Nov 19, 2024
@AlCalzone AlCalzone reopened this Nov 19, 2024
@AlCalzone
Copy link
Member

New approach: I uninstalled every dependency that indirectly depended on rollup
Added

  "overrides": {
    "rollup": "npm:@rollup/wasm-node"
  },

Then restored the removed entries in package.json and did npm install. Voila:
grafik

@robertsLando robertsLando merged commit 7048d05 into master Nov 19, 2024
10 checks passed
@robertsLando robertsLando deleted the rollup-issue branch November 19, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 9.27, unable to build from source
3 participants