Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): show association error in association dialog #3804

Merged
merged 14 commits into from
Jul 18, 2024

Conversation

robertsLando
Copy link
Member

Fixes #3801

@robertsLando robertsLando changed the title Associations-error feat(ui): show association error in association dialog Jul 9, 2024
@robertsLando robertsLando changed the base branch from zwave-js-13 to master July 18, 2024 12:20
@robertsLando robertsLando merged commit f919273 into master Jul 18, 2024
6 of 9 checks passed
@robertsLando robertsLando deleted the associations-error branch July 18, 2024 12:21
Copy link
Contributor

Pull Request Test Coverage Report for Build 9991372389

Details

  • 2 of 70 (2.86%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 21.029%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/lib/ZnifferManager.ts 0 1 0.0%
api/lib/Constants.ts 2 6 33.33%
src/lib/utils.js 0 7 0.0%
api/app.ts 0 9 0.0%
api/lib/ZwaveClient.ts 0 47 0.0%
Totals Coverage Status
Change from base Build 9974065135: 0.007%
Covered Lines: 3899
Relevant Lines: 19721

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show in the association dialog if and why an association is now allowed
2 participants