-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(discovery): add support for availability topics #3510
Conversation
require the client to be connected (LWT will set to false when MQTT connection is lost because the process goes down), the driver to be ready, and the individual node to be online
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! Did you tested it? Is it working well? I cannot test with HA or Domoticz as I don't use them.
You may need to wrap this in a method on the client and add it also to the discoverDevice method
I've tested it with the current releases of Home Assistant and openHAB (I primarily use the latter, and am the maintainer of its MQTT/Home Assistant compatibility layer). It's been working quite well - immediately showing the devices as offline if I kill zwave-js-ui, and then showing them as online when I restart it. |
@zwave-js-bot fix lint |
Pull Request Test Coverage Report for Build 7464892756
💛 - Coveralls |
so it can also be configured on custom devices
I've wrapped this in a method and tested the regular path, but I don't (currently) have any custom devices to test it with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for the rest!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Require the client to be connected (LWT will set to false when MQTT connection is lost because the process goes down), the driver to be ready, and the individual node to be online