Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add response timeout setting support #3325

Merged
merged 1 commit into from
Oct 6, 2023
+18 −2
Merged

feat: add response timeout setting support #3325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/ZwaveClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,7 @@ export type ZwaveConfig = {
logLevel?: LogManager.LogLevel
commandsTimeout?: number
sendToSleepTimeout?: number
responseTimeout?: number
enableStatistics?: boolean
disclaimerVersion?: number
options?: ZWaveOptions
Expand Down Expand Up @@ -2117,6 +2118,7 @@ class ZwaveClient extends TypedEventEmitter<ZwaveClientEventCallbacks> {
timeouts: {
report: this.cfg.higherReportsTimeout ? 10000 : undefined,
sendToSleep: this.cfg.sendToSleepTimeout,
response: this.cfg.responseTimeout,
},
userAgent: {
[pkgjson.name]: pkgjson.version,
Expand Down
18 changes: 16 additions & 2 deletions src/views/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,8 +807,22 @@
"
label="Send to sleep timeout"
required
suffix="seconds"
hint="How long to wait without pending commands before sending a node back to sleep"
persistent-hint
suffix="ms"
hint="How long to wait without pending commands before sending a node back to sleep. Leave blank to use default (250ms)"
type="number"
></v-text-field>
</v-col>
<v-col cols="6">
<v-text-field
v-model.number="
newZwave.responseTimeout
"
label="Response timeout"
required
persistent-hint
suffix="ms"
hint="How long to wait for a controller response. Leave blank to use default (10000ms)"
type="number"
></v-text-field>
</v-col>
Expand Down