Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): match text color with icon color on ZWave Graph legend #3299

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

PlasmaEye
Copy link
Contributor

@PlasmaEye PlasmaEye commented Sep 24, 2023

change the legend text color to match the legend icon's color.

Before (dark):
image

Before (light):
image

After (dark):
image

After (light):
image

@PlasmaEye PlasmaEye changed the title Match text color with icon color on ZWave Graph legend fix(graph): Match text color with icon color on ZWave Graph legend Sep 24, 2023
@PlasmaEye
Copy link
Contributor Author

PlasmaEye commented Sep 24, 2023

I feel like I've met the PR title requirements but the bot still isn't happy. What am I missing?

@robertsLando robertsLando changed the title fix(graph): Match text color with icon color on ZWave Graph legend fix(graph): match text color with icon color on ZWave Graph legend Sep 25, 2023
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it on purpose to make the text a bit less bright, btw seems that using same color makes everything more readable

@robertsLando robertsLando enabled auto-merge (squash) September 25, 2023 09:30
@robertsLando robertsLando merged commit f546160 into zwave-js:master Sep 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants