Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: bump zwave-js@12 and fix breaking changes #3268

Merged
merged 18 commits into from
Sep 26, 2023
Merged

feat!: bump zwave-js@12 and fix breaking changes #3268

merged 18 commits into from
Sep 26, 2023

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Sep 7, 2023 •
edited
Loading

@robertsLando robertsLando changed the title feat: bump zwave-js@12 and fix breaking changes feat!: bump zwave-js@12 and fix breaking changes Sep 7, 2023
@robertsLando
Copy link
Member Author

cc @AlCalzone

AlCalzone
AlCalzone requested changes Sep 11, 2023
View reviewed changes
src/views/ControlPanel.vue Outdated Show resolved Hide resolved
src/views/ControlPanel.vue Outdated Show resolved Hide resolved
lib/ZwaveClient.ts Outdated Show resolved Hide resolved
lib/ZwaveClient.ts Show resolved Hide resolved
AlCalzone
AlCalzone reviewed Sep 11, 2023
View reviewed changes
lib/ZwaveClient.ts Outdated Show resolved Hide resolved
AlCalzone
AlCalzone reviewed Sep 25, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6310153452

  • 0 of 146 (0.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 21.52%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/SocketEvents.ts 0 1 0.0%
src/components/nodes-table/nodes-table.js 0 1 0.0%
src/lib/SocketEvents.js 0 1 0.0%
src/stores/base.js 0 3 0.0%
src/mixins/InstancesMixin.js 0 12 0.0%
lib/ZwaveClient.ts 0 128 0.0%
Totals Coverage Status
Change from base Build 6310143062: -0.03%
Covered Lines: 3674
Relevant Lines: 18175
💛 - Coveralls

AlCalzone
AlCalzone reviewed Sep 26, 2023
View reviewed changes
src/stores/base.js Outdated Show resolved Hide resolved
@robertsLando robertsLando merged commit 6ea201b into master Sep 26, 2023
10 checks passed
@robertsLando robertsLando deleted the zwave-js@12 branch September 26, 2023 15:45
@robertsLando robertsLando mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertsLando @coveralls @AlCalzone @raman325