feat(config): update Zooz ZSE11 with 800LR specific params #7537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
requested changes
Jan 13, 2025
Comment on lines
-11
to
+23
| "zwaveAllianceId": 4152 | ||
| "zwaveAllianceId": [ | ||
| { | ||
| "$if": "firmwareVersion >= 2.0", | ||
| "value": 5112 | ||
| }, | ||
| 4152 | ||
| ] |
There was a problem hiding this comment.
This doesn't work. Just put both numbers in the same array.
Comment on lines
+102
to
+106
| { | ||
| "#": "21", | ||
| "$if": "firmwareVersion >= 2.0", | ||
| "label": "Light Sensor Checking Interval", | ||
| "description": "Set the frequency interval for lux value verification. This is how often the sensor will probe the environment for lux value changes. NOTE: a report will be sent ONLY if the value has changed by the threshold value set in Parameter 185 as compared to the most recent report.", |
There was a problem hiding this comment.
Regarding this parameter and the following: Zooz parameter descriptions are terribly verbose and tend to repeat themselves in the label, description and option labels. We prefer keeping things short since they will be displayed on constrained UIs.
Ideally align these with how I did it in this PR, so we can extract them into templates in a followup PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description here
Zooz ZSE11 had multiple param updates with the 800LR revision. Pulled information from firmware changelog, device's advanced settings page and the ZWA link