Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add ZSE70 device file; Add additional templates to Zooz template file #7490

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

akennerly
Copy link
Contributor

Add Zooz ZSE70

@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Dec 12, 2024
@akennerly akennerly changed the title Add ZSE70 device file; Add additional templates to Zooz template file feat(config): Add ZSE70 device file; Add additional templates to Zooz template file Dec 12, 2024
@akennerly akennerly changed the title feat(config): Add ZSE70 device file; Add additional templates to Zooz template file feat(config): add ZSE70 device file; Add additional templates to Zooz template file Dec 12, 2024
@akennerly
Copy link
Contributor Author

I'm at loss in seeing where the lint test is failing.

@kpine
Copy link
Contributor

kpine commented Dec 12, 2024

I'm at loss in seeing where the lint test is failing.

You can run yarn fmt in your dev environment and it will fix the formatting issue for you. The lint command that is failing is yarn fmt:check but it hides the output. yarn exec dprint check will show the entire output, which is just the filename and diff output.

diff --git a/packages/config/config/devices/0x027a/zse70.json b/packages/config/config/devices/0x027a/zse70.json
index c54a9a7..6ca77d1 100644
--- a/packages/config/config/devices/0x027a/zse70.json
+++ b/packages/config/config/devices/0x027a/zse70.json
@@ -110,11 +110,11 @@
 			"minValue": 0,
 			"defaultValue": 2,
 			"options": [
-			{
-				"label": "Disable",
-				"value": 0
-			}
-		]
+				{
+					"label": "Disable",
+					"value": 0
+				}
+			]
 		},
 		{
 			"#": "12",
@@ -144,7 +144,6 @@
 			"#": "18",
 			"$import": "templates/zooz_template.json#lux_report_frequency"
 		}
-		
 	],
 	"metadata": {
 		"wakeup": "Press the Z-Wave button to wake the device up. The LED will start flashing.",
$ yarn exec dprint check
from /workspaces/node-zwave-js/packages/config/config/devices/0x027a/zse70.json:
110 110| →→→"minValue":·0,
111 111| →→→"defaultValue":·2,
112 112| →→→"options":·[
    113|-→→→{
    114|-→→→→"label":·"Disable",
    115|-→→→→"value":·0
    116|-→→→}
    117|-→→]
113    |+→→→→{
114    |+→→→→→"label":·"Disable",
115    |+→→→→→"value":·0
116    |+→→→→}
117    |+→→→]
118 118| →→},
119 119| →→{
120 120| →→→"#":·"12",
...
144 144| →→→"#":·"18",
145 145| →→→"$import":·"templates/zooz_template.json#lux_report_frequency"
146 146| →→}
    147|-→→
147 148| →],
148 149| →"metadata":·{
149 150| →→"wakeup":·"Press·the·Z-Wave·button·to·wake·the·device·up.·The·LED·will·start·flashing.",
--
Found 1 not formatted file.

@hceuterpe
Copy link

hceuterpe commented Dec 13, 2024

Btw, I created a pull request for this already a few weeks ago. Hasn't been merged yet though.

#7405

@kpine
Copy link
Contributor

kpine commented Dec 13, 2024

Btw, I created a pull request for this already a few weeks ago. Hasn't been merged yet though.

Your link got mangled, it's #7405. Which is confusing because your PR doesn't add any new files. Turns out the actual PR adding the config is at #7381, which would need to be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants