Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate from Node.js streams to Web Streams API #7457

Merged
merged 16 commits into from
Dec 9, 2024

Conversation

AlCalzone
Copy link
Member

@AlCalzone AlCalzone commented Dec 4, 2024

Continuing the work of making node-zwave-js more portable, this PR refactors the usage of streams to be compatible with the Web Streams API, rather than Node.js streams.

packages/serial/src/parsers/BootloaderParsers.ts Dismissed Show dismissed Hide dismissed
packages/serial/src/parsers/ZnifferParser.ts Fixed Show fixed Hide fixed
packages/serial/src/serialport/ZWaveSerialStream.test.ts Dismissed Show dismissed Hide dismissed
test/run.ts Dismissed Show dismissed Hide dismissed
@AlCalzone AlCalzone force-pushed the web-streams branch 3 times, most recently from f7073c3 to 46ca103 Compare December 9, 2024 10:33
@AlCalzone AlCalzone marked this pull request as ready for review December 9, 2024 13:19
constructor(
logger?: SerialLogger,
) {
super(new BootloaderScreenParserTransformer(logger));

Check warning

Code scanning / CodeQL

Superfluous trailing arguments Warning

Superfluous argument passed to
function TransformStream
.

Copilot Autofix AI 19 days ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

logger?: SerialLogger,
) {
const transformer = new SerialAPIParserTransformer(logger);
super(transformer);

Check warning

Code scanning / CodeQL

Superfluous trailing arguments Warning

Superfluous argument passed to
function TransformStream
.

Copilot Autofix AI 19 days ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

constructor(
logger?: SerialLogger,
) {
super(new ZnifferParserTransformer(logger));

Check warning

Code scanning / CodeQL

Superfluous trailing arguments Warning

Superfluous argument passed to
function TransformStream
.

Copilot Autofix AI 19 days ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

@AlCalzone
Copy link
Member Author

@zwave-js-bot automerge

@zwave-js-bot zwave-js-bot merged commit 863244e into master Dec 9, 2024
25 checks passed
@zwave-js-bot zwave-js-bot deleted the web-streams branch December 9, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants