-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: argument validation of parameters with defaults, Map and Set #7435
Conversation
@zwave-js-bot automerge |
class Test { | ||
@validateArgs() | ||
foo(arg1: number = 5): void { | ||
arg1; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
|
||
@validateArgs() | ||
bar(arg1: number | string = 5): void { | ||
arg1; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
class Test { | ||
@validateArgs() | ||
map(arg1: Map<any, any>): void { | ||
arg1; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
|
||
@validateArgs() | ||
readonlyMap(arg1: ReadonlyMap<any, any>): void { | ||
arg1; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
|
||
@validateArgs() | ||
set(arg1: Set<any>): void { | ||
arg1; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
|
||
@validateArgs() | ||
readonlySet(arg1: ReadonlySet<any>): void { | ||
arg1; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
### Bugfixes * Fixed another issue where some CC API methods would incorrectly fail validation of their arguments, causing the node interview to fail (#7435)
fixes the issue reported in #7430 (reply in thread)