Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validation of rest parameters #7433

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: validation of rest parameters #7433

merged 1 commit into from
Nov 22, 2024

Conversation

AlCalzone
Copy link
Member

@AlCalzone AlCalzone commented Nov 22, 2024 •
edited
Loading

fixes: #7434

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 22, 2024
View reviewed changes
packages/transformers/test/fixtures/testSpread.mts
class Test {
@validateArgs()
foo(...args: number[]): void {
args;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
packages/transformers/test/fixtures/testSpread.mts

@validateArgs()
bar(arg1: string, ...rest: boolean[]): void {
arg1;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
packages/transformers/test/fixtures/testSpread.mts
@validateArgs()
bar(arg1: string, ...rest: boolean[]): void {
arg1;
rest;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
@AlCalzone
Copy link
Member Author

@zwave-js-bot automerge

@zwave-js-bot zwave-js-bot merged commit 44e40da into master Nov 22, 2024
23 checks passed
@zwave-js-bot zwave-js-bot deleted the validateargs-spread branch November 22, 2024 12:56
AlCalzone added a commit that referenced this pull request Nov 22, 2024
@AlCalzone
chore: release v14.3.5
dcec676 
### Bugfixes
* Fixed an issue that prevented the `nvmedit` CI utility from starting (#7432)
* Fixed an issue where some CC API methods would incorrectly fail validation of their arguments (#7433)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwave-js-bot zwave-js-bot zwave-js-bot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation of rest parameters is broken
2 participants
@AlCalzone @zwave-js-bot