Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add HomeSys HomeMech-2001/2 #7400

Merged
merged 18 commits into from
Nov 13, 2024

Conversation

aweddell
Copy link
Contributor

Add new device config for HomeSys HomeMech-2001 and HomeMech-2002 dimmers

@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Nov 13, 2024
@AlCalzone
Copy link
Member

Here, let me fix that for you

@aweddell
Copy link
Contributor Author

Here, let me fix that for you

Amazing, thank you! That lint error was breaking my brain as it wasn't throwing in the local env.

Appreciate you!

Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few remarks

packages/config/config/devices/0x0330/homemech-200X.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0330/homemech-200X.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0330/homemech-200X.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0330/homemech-200X.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0330/homemech-200X.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0330/homemech-200X.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0330/homemech-200X.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0330/homemech-200X.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0330/homemech-200X.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0330/homemech-200X.json Outdated Show resolved Hide resolved
@AlCalzone
Copy link
Member

That lint error was breaking my brain as it wasn't throwing in the local env.

You probably ran the wrong check (semantic instead of just formatting). Command Palette -> Format Document would have done it btw.

@aweddell aweddell requested a review from AlCalzone November 13, 2024 14:31
@AlCalzone AlCalzone merged commit a89bcf7 into zwave-js:master Nov 13, 2024
25 checks passed
AlCalzone added a commit that referenced this pull request Nov 14, 2024
### Bugfixes
* Fix parsing of some older 500 series NVM formats (#7399)
* Fixed an issue where `mock-server` would not start due to an incorrect module format (#7401)
* Fixed an issue where the auto-generated argument validation for CC API methods would not work correctly in some cases when `zwave-js` was bundled (#7403)

### Config file changes
* Add HomeSys HomeMech-2001/2 (#7400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants