fix: detect bootloader when short chunks are received #7318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Oct 24, 2024
AlCalzone
added a commit
that referenced
this pull request
Oct 25, 2024
### Bugfixes * Correct unit of Meter CC values (#7322) * Bootloader mode is now detected even when short chunks of data are received (#7318) * Corrected the wording of idle/busy queue logging (#7309) ### Config file changes * Add Heatit Z-TEMP3 (#7179) * Add new parameters 17 and 18 for HeatIt TF016_TF021 FW 1.92 (#7287) * Disable Supervision for Heatit TF021 (#7321) * Add ZVIDAR WB04V Smartwings Day Night Shades (#7319) * Add ZVIDAR WM25L Smartwings Smart Motor (#7312) * Add ZVIDAR ZW881 Multi-Protocol Gateway (#7311) * Add include, exclude, and wakeup instructions for VCZ1 (#7307) * Add new Product ID to Namron 16A Switch (#7301) * Add Minoston MP24Z 800LR Outdoor Smart Plug - 2 Outlet (#7302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7316
The problem was that the first received chunk was just 16 bytes, including newlines and did not contain the full sequence "Gecko Bootloader". By shortening the preamble used for detection, this is now handled correctly.