feat: skip rebuilding routes for nodes with priority return routes #7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @robertsLando this might need a new checkbox in the rebuild routes dialog, under the "include sleeping nodes" one. |
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Oct 8, 2024
5 tasks
AlCalzone
added a commit
that referenced
this pull request
Oct 10, 2024
### Features * Skip rebuilding routes for nodes with priority return routes (#7252) * Add `node info received` event (#7253) * OTA firmware updates now use the task scheduler. This allows running multiple OTA updates at once. (#7256) * Implement Multilevel Switch mocks, add default state for Binary Switch mocks (#7270) ### Bugfixes * Use configured network keys on secondary controller if learned keys are absent (#7226) * Pending tasks are removed when hard-resetting or entering bootloader (#7255) ### Config file changes * Add incompatibility warning to UZB1 (#7225) * Override Central Scene CC version for Springs Window Fashions VCZ1 (#7263) ### Changes under the hood * Dependency updates * Fix bootstrap command in devcontainer (#7254)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, full-network route rebuilding will skip nodes with priority return routes (end node or SUC) by default, unless the new
deletePriorityReturnRoutesoption is set totrue.Note that rebuilding routes for a single node will still delete existing priority return routes to end nodes and the SUC. It is recommended to first check if priority return routes are known to exist using
getPriorityReturnRoutesCachedandgetPrioritySUCReturnRouteCachedand asking for confirmation before proceeding.fixes: #7147