Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): correct max. value of SKU parameters for Kwikset locks #7178

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Sep 19, 2024

Without this, when using ZWave-JS-UI, openHAB is complaining that the value my locks are reporting is not in range 0 to 0.

@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Sep 19, 2024
@ccutrer ccutrer force-pushed the kwikset-lock-config-fix branch from efb7e87 to 9146b62 Compare September 19, 2024 20:17
@ccutrer ccutrer changed the title fix(config): SKU bytes can be something besides 0 fix(config): sky bytes can be something besides 0 Sep 19, 2024
@ccutrer ccutrer changed the title fix(config): sky bytes can be something besides 0 fix(config): sku bytes can be something besides 0 Sep 19, 2024
@AlCalzone AlCalzone changed the title fix(config): sku bytes can be something besides 0 fix(config): correct max. value of SKU parameters for Kwikset locks Sep 25, 2024
@AlCalzone
Copy link
Member

Should those parameters be readonly? Sounds like they are, but they are currently not marked that way.

AlCalzone
AlCalzone previously approved these changes Sep 25, 2024
@ccutrer
Copy link
Contributor Author

ccutrer commented Sep 25, 2024

You're correct, they're read only. I just tried to update it in ZWave JS UI, and it reverted back after a second.

@AlCalzone AlCalzone enabled auto-merge (squash) October 7, 2024 08:43
@AlCalzone AlCalzone merged commit f4dcda4 into zwave-js:master Oct 7, 2024
16 checks passed
AlCalzone added a commit that referenced this pull request Oct 7, 2024
This release adds an internal task scheduler that will allow more control over longer running tasks like device interviews, route rebuilding, firmware updates, etc. These improvements include pausing/resuming tasks, better prioritization for user-initiated actions, queueing tasks without interrupting ongoing ones, and more. Migration of existing features to the new scheduler will be done incrementally, starting with route rebuilding.

### Features
* Reworked route rebuilding to use the task scheduler. This enables rebuilding routes for multiple individual nodes at once. (#7196, #7203)

### Bugfixes
* Fixed a regression from `13.4.0` that prevented restoring NVM backups on 700/800 series controllers (#7220)

### Config file changes
* Add fingerprint to Aeotec ZWA024 (#7191)
* Correct max. value of SKU parameters for Kwikset locks (#7178)
* Add fingerprint to Remotec ZXT-800 (#7195)

### Changes under the hood
* Implement task scheduler (#7193)
* Upgrade to ESLint v9, typescript-eslint v8 (#6987)
* Update FAQ on secondary controllers (#7190)
@ccutrer ccutrer deleted the kwikset-lock-config-fix branch October 7, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants