-
-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respond to more queries from other devices, handle supervised queries correctly, harden S2 extension parsing and validation #6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
changed the title
fix: respond to more queries from other devices, handle supervised queries correctly
fix: respond to more queries from other devices, handle supervised queries correctly, harden S2 extension parsing
May 24, 2024
AlCalzone
added
the
Spec compliance 👮🏻♂️
Needs to be done to comply with the specifications
label
May 24, 2024
AlCalzone
changed the title
fix: respond to more queries from other devices, handle supervised queries correctly, harden S2 extension parsing
fix: respond to more queries from other devices, handle supervised queries correctly, harden S2 extension parsing and validation
May 29, 2024
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
May 29, 2024
AlCalzone
added a commit
that referenced
this pull request
Jun 5, 2024
### Features * Support `SendTestFrame` command and perform powerlevel tests on behalf of other nodes (#6889) ### Bugfixes * Respond to more queries from other devices (#6866) * Handle supervised queries from other devices correctly (#6866) * Harden S2 extension parsing and validation (#6866) * Fixed some more edge cases found by S2 certification tests (#6887) * Abort S2 bootstrapping when CSA is requested (not supported in Z-Wave JS) (#6890) ### Config file changes * Parameter update for Zooz Zen16 v2.0 and v2.10 (#6855) * Override Central Scene CC version for Springs Window Fashions BRZ (#6870)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a lot of small deviations from the specifications and the handling of edge cases the CTT uses to test implementations. Also adds a lot of mandatory responses to queries that weren't handled before.
fixes: #6865
fixes: #6864