Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not persist or map values form force-removed CCs, do not persist values from mapped CCs #6760

Merged
merged 7 commits into from
Apr 11, 2024

Conversation

AlCalzone
Copy link
Member

@AlCalzone AlCalzone commented Apr 11, 2024

This fixes a long-standing issue where seemingly unsupported values appear for CCs that have been force-removed via a config file.

fixes #6555
TODO: solve #6318 as a followup

@AlCalzone AlCalzone changed the title fix: do not persist or map values form force-removed CCs fix: do not persist or map values form force-removed CCs, do not persist values from mapped CCs Apr 11, 2024
@AlCalzone
Copy link
Member Author

@zwave-js-bot automerge

zwave-js-bot
zwave-js-bot previously approved these changes Apr 11, 2024
@zwave-js-bot zwave-js-bot enabled auto-merge (squash) April 11, 2024 12:35
@AlCalzone AlCalzone disabled auto-merge April 11, 2024 12:35
@AlCalzone AlCalzone enabled auto-merge (squash) April 11, 2024 12:35
zwave-js-bot
zwave-js-bot previously approved these changes Apr 11, 2024
zwave-js-bot
zwave-js-bot previously approved these changes Apr 11, 2024
@AlCalzone AlCalzone merged commit b924bb5 into master Apr 11, 2024
17 checks passed
@AlCalzone AlCalzone deleted the ignore-removed-ccs branch April 11, 2024 13:22
AlCalzone added a commit that referenced this pull request Apr 12, 2024
### Bugfixes
* Firmware updates on Z-Wave Long Range now utilize the larger frame size better (#6759)
* Fixed an issue where multicast `setValue` had a `SupervisionCCReport` as the result instead of a `SetValueResult` (#6765)
* Parsing of provisioning entries with numeric `supportedProtocols` (#6764)
* Fix error when `ConfigurationCCBulkGet` response is missing (#6763)
* Values from force-removed or endpoint-mapped CCs are no longer persisted (#6760)

### Config file changes
* Fix versioning logic for parameter 26 of Zooz ZEN72 (#6761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping root reports to an endpoint via compat flags still exposes the value on the root
2 participants