Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dprint #6656

Merged
merged 4 commits into from
Apr 4, 2024
Merged

chore: upgrade dprint #6656

merged 4 commits into from
Apr 4, 2024

Conversation

AlCalzone
Copy link
Member

PR description here

@zackbcom
Copy link
Contributor

zackbcom commented Feb 10, 2024

I tried this on Arm mac and still needs the prettier arm version. There is a PR to add it.

We might want to add dprint install to the devcontainer for use with the vscode extensoin drpint.

Extensions install steps: Install dprint's CLI

I don't think it comes installed. or it's not on the path.
curl -fsSL https://dprint.dev/install.sh | sh

and need to add some lines to the .zshrc file:

export DPRINT_INSTALL="/home/node/.dprint"
export PATH="$DPRINT_INSTALL/bin:$PATH"

Edit: we might be able to add this to vscode settings:
"dprint.path":"./node_modules/dprint/dprint",

@AlCalzone
Copy link
Member Author

I opened an issue with your remarks

@AlCalzone AlCalzone marked this pull request as ready for review April 4, 2024 17:32
@AlCalzone
Copy link
Member Author

@zwave-js-bot automerge

@zwave-js-bot zwave-js-bot enabled auto-merge (squash) April 4, 2024 17:33
@zwave-js-bot zwave-js-bot merged commit 759d792 into master Apr 4, 2024
16 checks passed
@zwave-js-bot zwave-js-bot deleted the upgrade-dprint branch April 4, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants